zhongjiajie commented on code in PR #9534:
URL: https://github.com/apache/dolphinscheduler/pull/9534#discussion_r852543685
##########
docs/docs/en/guide/alert/alert_plugin_user_guide.md:
##########
@@ -2,7 +2,11 @@
## How to Create Alert Plugins and Alert Groups
-In version 2.0.0, users need to create alert instances, and then associate
them with alert groups. Alert group can use multiple alert instances and notify
them one by one.
+In version 2.0.0, users need to create alert instances, and needs to choose
alarm policy when defining an alarm instance, there are three options: send if
the task succeeds, send on failure, and send on both success and failure. when
the workflow or task is executed, if an alarm is triggered, calling the alarm
instance send method needs a logical judgment, which matches the alarm instance
with the task status, executes the alarm instance sending logic if it matches,
and filters if it does not match. When create alert instances then associate
them with alert groups. Alert group can use multiple alert instances.
Review Comment:
```suggestion
In version 2.0.0, users need to create alert instances, and needs to choose
an alarm policy when defining an alarm instance, there are three options: send
if the task succeeds, send on failure, and send on both success and failure.
when the workflow or task is executed, if an alarm is triggered, calling the
alarm instance send method needs a logical judgment, which matches the alarm
instance with the task status, executes the alarm instance sending logic if it
matches, and filters if it does not match. When create alert instances then
associate them with alert groups. Alert group can use multiple alert instances.
```
##########
docs/docs/en/development/backend/spi/alert.md:
##########
@@ -22,7 +22,7 @@ If you don't care about its internal design, but simply want
to know how to deve
* dolphinscheduler-alert-plugins
- This module is currently a plug-in provided by us, such as Email, DingTalk,
Script, etc.
+ This module is currently a plug-in provided by us, and now we have supported
ten plug-ins, such as Email, DingTalk, Script, etc.
Review Comment:
I prefer to keep it in the old content, if we specify the number of our
plugins, we should change this number every time we add plugins. I think most
people will forget to modify it, WDYT？
```suggestion
This module is currently a plug-in provided by us, such as Email,
DingTalk, Script, etc.
```
##########
docs/docs/zh/development/backend/spi/alert.md:
##########
@@ -22,7 +22,7 @@ DolphinScheduler 正在处于微内核 + 插件化的架构更改之中，所有
* dolphinscheduler-alert-plugins
- 该模块是目前我们提供的插件，如 Email、DingTalk、Script等。
+ 该模块是目前我们提供的插件，目前我们已经支持数十种插件，如 Email、DingTalk、Script等。
Review Comment:
Same as English doc as I said.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
