paul8263 commented on code in PR #9577: URL: https://github.com/apache/dolphinscheduler/pull/9577#discussion_r853916999
########## dolphinscheduler-task-plugin/dolphinscheduler-task-flink/src/main/java/org/apache/dolphinscheduler/plugin/task/flink/FlinkDeployMode.java: ########## @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.dolphinscheduler.plugin.task.flink; + +import com.fasterxml.jackson.annotation.JsonProperty; + +/** + * Flink deploy mode + */ +public enum FlinkDeployMode { Review Comment: Hi @SbloodyS ， `local` and `yarn-cluster` is for Flink legacy version, while `yarn-session` and `yarn-per-job` is for newer version. Legacy Flink: `flink run [-m yarn-cluster] xxx` Newer Flink: `flink run/run-application -t /yarn-per-job/yarn-session/yarn-application` The `local` mode in newer Flink is session mode and `yarn-cluster` is `yarn-per-job` as well, while yarn-application is brand new. Newer Flink can also accept legacy deploy mode parameters. So personally I suggest we keep using the legacy ones in order to ensure its compability. Correct me if I am wrong. See [Flink-1.11 Yarn](https://nightlies.apache.org/flink/flink-docs-release-1.11/ops/deployment/yarn_setup.html#run-a-single-flink-job-on-yarn) and [Flink-1.12 Yarn](https://nightlies.apache.org/flink/flink-docs-release-1.12/deployment/resource-providers/yarn.html#per-job-cluster-mode). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
