zhongjiajie commented on code in PR #9651:
URL: https://github.com/apache/dolphinscheduler/pull/9651#discussion_r855715136
##########
docs/configs/docsdev.js:
##########
@@ -119,7 +119,7 @@ export default {
link:
'/en-us/docs/dev/user_doc/guide/task/dependent.html',
},
{
- title: 'Stored Procedure',
+ title: 'PROCEDURE',
Review Comment:
```suggestion
title: 'Procedure',
```
##########
docs/docs/en/guide/task/stored-procedure.md:
##########
@@ -8,6 +8,32 @@
<img src="/img/procedure-en.png" width="80%" />
</p>
-- DataSource: The DataSource type of the stored procedure supports MySQL and
POSTGRESQL, select the corresponding DataSource.
-- Method: The method name of the stored procedure.
-- Custom parameters: The custom parameter types of the stored procedure
support `IN` and `OUT`, and the data types support: VARCHAR, INTEGER, LONG,
FLOAT, DOUBLE, DATE, TIME, TIMESTAMP and BOOLEAN.
\ No newline at end of file
+- Node name: The node name in a workflow definition is unique.
+- Run flag: Identifies whether this node schedules normally, if it does not
need to execute, select the `prohibition execution`.
+- Descriptive information: Describe the function of the node.
+- Task priority: When the number of worker threads is insufficient, execute in
the order of priority from high to low, and tasks with the same priority will
execute in a first-in first-out order.
+- Worker grouping: Assign tasks to the machines of the worker group to
execute. If `Default` is selected, randomly select a worker machine for
execution.
+- Environment Name: Configure the environment name in which run the script.
+- Times of failed retry attempts: The number of times the task failed to
resubmit.
+- Failed retry interval: The time interval (unit minute) for resubmitting the
task after a failed task.
+- Delayed execution time: The time (unit minute) that a task delays in
execution.
+- Timeout alarm: Check the timeout alarm and timeout failure. When the task
runs exceed the "timeout", an alarm email will send and the task execution will
fail.
+- DataSource: The DataSource type of the stored procedure supports
MySQL,POSTGRESQL,HIVE,SPARK,CLICKHOUSE,ORACLE,SQLSERVER,DB2 and PRESTO, select
the corresponding DataSource.
Review Comment:
```suggestion
- DataSource: The DataSource type of the stored procedure supports
MySQL,POSTGRESQL,HIVE,SPARK,CLICKHOUSE,ORACLE,SQLSERVER,DB2 and PRESTO.
```
##########
docs/configs/docsdev.js:
##########
@@ -433,7 +433,7 @@ export default {
link:
'/zh-cn/docs/dev/user_doc/guide/task/dependent.html',
},
{
- title: 'Stored Procedure',
+ title: 'PROCEDURE',
Review Comment:
```suggestion
title: 'Procedure,
```
##########
docs/docs/en/guide/task/stored-procedure.md:
##########
@@ -8,6 +8,32 @@
<img src="/img/procedure-en.png" width="80%" />
</p>
-- DataSource: The DataSource type of the stored procedure supports MySQL and
POSTGRESQL, select the corresponding DataSource.
-- Method: The method name of the stored procedure.
-- Custom parameters: The custom parameter types of the stored procedure
support `IN` and `OUT`, and the data types support: VARCHAR, INTEGER, LONG,
FLOAT, DOUBLE, DATE, TIME, TIMESTAMP and BOOLEAN.
\ No newline at end of file
+- Node name: The node name in a workflow definition is unique.
Review Comment:
you should change the document like
https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/guide/task/sql.md.
We have section `Overview ` and section `Create DataSource`
##########
docs/configs/docsdev.js:
##########
@@ -433,7 +433,7 @@ export default {
link:
'/zh-cn/docs/dev/user_doc/guide/task/dependent.html',
},
{
- title: 'Stored Procedure',
+ title: 'PROCEDURE',
Review Comment:
If you change the sidebar title, you should also change the title in content
`Stored Prcedure`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
