SbloodyS commented on code in PR #9614:
URL: https://github.com/apache/dolphinscheduler/pull/9614#discussion_r857062411
##########
script/scp-hosts.sh:
##########
@@ -47,11 +42,17 @@ do
echo "scp dirs to $host/$installPath starting"
ssh -p $sshPort $host "cd $installPath/; rm -rf bin/ conf/ lib/
script/ sql/ ui/"
+ for i in ${!workerNames[@]}; do
+ if [[ ${workerNames[$i]} == $host ]]; then
+ workerIndex=$i
+ break
+ fi
+ done
+
for dsDir in bin master-server worker-server alert-server api-server ui
do
- # if worker in workersGroupMap
- if [[ "${workersGroupMap[${host}]}" ]]; then
- echo "export WORKER_GROUPS_0=${workersGroupMap[${host}]}" >>
worker-server/bin/dolphinscheduler_env.sh
+ if [[ ! -z ${workerIndex+x} ]]; then
Review Comment:
Would it be better to use ```if [[ -n ${workerIndex} ]]```?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
