[GitHub] [dolphinscheduler] zhuangchong commented on a diff in pull request #9917: [Feature-9177][Task] The sql task supports configuring segmentation notation to provide execution of multiple statements

Sat, 07 May 2022 20:57:29 -0700 


zhuangchong commented on code in PR #9917:
URL: https://github.com/apache/dolphinscheduler/pull/9917#discussion_r867430975


##########
dolphinscheduler-ui/src/views/projects/task/components/node/tasks/use-sql.ts:
##########
@@ -46,6 +46,7 @@ export function useSql({
     timeout: 30,
     type: 'MYSQL',
     displayRows: 10,
+    segmentSeparator: '',

Review Comment:
   @SbloodyS 
   This suggestion is very good. I think whether this parameter needs to be 
related to the data source, provide default values ​​for different data 
sources, but this will change the data source module. I hope to optimize in the 
next PR, let SQLTask support this function first, and then provide different 
data sources to change the value of this parameter, what do you think?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to