zhongjiajie commented on code in PR #9995: URL: https://github.com/apache/dolphinscheduler/pull/9995#discussion_r872516954
########## docs/docs/en/development/development-environment-setup.md: ########## @@ -5,10 +5,9 @@ Before setting up the DolphinScheduler development environment, please make sure you have installed the software as below: * [Git](https://git-scm.com/downloads): DolphinScheduler version control system -* [JDK](https://www.oracle.com/technetwork/java/javase/downloads/index.html): DolphinScheduler backend language +* [JDK1.8](https://www.oracle.com/technetwork/java/javase/downloads/index.html): DolphinScheduler backend language Review Comment: I prefer using content in the tail of this line, because the link https://www.oracle.com/technetwork/java/javase/downloads/index.html could download all version of jdk, and is not specific to version 1.8. same as `Node` ```suggestion * [JDK](https://www.oracle.com/technetwork/java/javase/downloads/index.html): DolphinScheduler backend language, have to use version after JDK 1.8 ``` ########## docs/docs/en/development/development-environment-setup.md: ########## @@ -52,7 +49,7 @@ Find the class `org.apache.dolphinscheduler.server.StandaloneServer` in Intellij ### Start frontend server -Install frontend dependencies and run it +Install frontend dependencies and run it, you can see frontend-development.md Review Comment: I think we should add content after running front end command(in L59) ```md > Note: You can see more detail about the frontend setting in [frontend development](./frontend-development.md) ``` ########## docs/docs/en/development/development-environment-setup.md: ########## @@ -52,7 +49,7 @@ Find the class `org.apache.dolphinscheduler.server.StandaloneServer` in Intellij ### Start frontend server -Install frontend dependencies and run it +Install frontend dependencies and run it, you can see frontend-development.md Review Comment: ```suggestion Install frontend dependencies and run it ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
