ruanwenjun commented on code in PR #10631:
URL: https://github.com/apache/dolphinscheduler/pull/10631#discussion_r908107870
##########
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/OSUtils.java:
##########
@@ -460,23 +460,23 @@ public static int getProcessID() {
}
/**
- * check memory and cpu usage
+ * Check memory and cpu usage is overload the given thredshod.
*
- * @param maxCpuloadAvg maxCpuloadAvg
+ * @param maxCpuLoadAvg maxCpuLoadAvg
* @param reservedMemory reservedMemory
- * @return check memory and cpu usage
+ * @return True, if the cpu or memory exceed the given thredshod.
*/
- public static Boolean checkResource(double maxCpuloadAvg, double
reservedMemory) {
+ public static Boolean checkOverload(double maxCpuLoadAvg, double
reservedMemory) {
Review Comment:
Thanks for your suggestion, agree with you.
##########
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/OSUtils.java:
##########
@@ -460,23 +460,23 @@ public static int getProcessID() {
}
/**
- * check memory and cpu usage
+ * Check memory and cpu usage is overload the given thredshod.
*
- * @param maxCpuloadAvg maxCpuloadAvg
+ * @param maxCpuLoadAvg maxCpuLoadAvg
* @param reservedMemory reservedMemory
- * @return check memory and cpu usage
+ * @return True, if the cpu or memory exceed the given thredshod.
*/
- public static Boolean checkResource(double maxCpuloadAvg, double
reservedMemory) {
+ public static Boolean checkOverload(double maxCpuLoadAvg, double
reservedMemory) {
Review Comment:
Thanks for your suggestion, agree with you. Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
