huangchenguang123 commented on code in PR #10821:
URL: https://github.com/apache/dolphinscheduler/pull/10821#discussion_r918523562
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteRunnable.java:
##########
@@ -1300,6 +1301,10 @@ public void getPreVarPool(TaskInstance taskInstance,
Set<String> preTask) {
}
if (allProperty.size() > 0) {
taskInstance.setVarPool(JSONUtils.toJsonString(allProperty.values()));
+ Map<String, Object> taskParams =
JSONUtils.parseObject(taskInstance.getTaskParams(), new
TypeReference<Map<String, Object>>() {
+ });
+ taskParams.put("varPool",
JSONUtils.toJsonString(allProperty.values()));
Review Comment:
localParams is currently useful, but this is limited to [in] parameters, but
for upstream [out] parameters, spark sql currently doesn't work, which is why I
use varPool.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]