ChPi commented on PR #13296: URL: https://github.com/apache/dolphinscheduler/pull/13296#issuecomment-1370431716
> it seems we design to skip parameter replace when without local and global parameter? Am I right? @SbloodyS @zhuangchong > > https://github.com/apache/dolphinscheduler/blob/70ccffeee25d3836604367961830c292fbba8659/dolphinscheduler-task-plugin/dolphinscheduler-task-sql/src/main/java/org/apache/dolphinscheduler/plugin/task/sql/SqlTask.java#L481-L488 if it must need local or global parameter, its better to add some note for document. but i check the `replaceScheduleTime`, its ok for calling `replaceScheduleTime` at first ,because it only replace some date parameters, its friendly for user which use date parameters without other parameters. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
