KEN-LJQ commented on code in PR #13403:
URL:
https://github.com/apache/dolphinscheduler/pull/13403#discussion_r1073496823
##########
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/registry/MasterRegistryClient.java:
##########
@@ -317,11 +317,14 @@ private boolean checkTaskAfterServerStart(List<Server>
servers, TaskInstance tas
return false;
}
- Date taskTime = taskInstance.getStartTime() == null ?
taskInstance.getSubmitTime() : taskInstance.getStartTime();
-
- Date serverStartDate = getServerStartupTime(servers,
taskInstance.getHost());
- if (serverStartDate != null) {
- return taskTime.after(serverStartDate);
+ Date taskSubmitTime = taskInstance.getSubmitTime();
+ Date serverStartTime = getServerStartupTime(servers,
taskInstance.getHost());
+ if (taskSubmitTime != null && serverStartTime != null &&
taskSubmitTime.after(serverStartTime)) {
+ logger.info(
+ "The taskInstance's submitTime: {} is after the need
failover server's start time: {}, the taskInstance is newly submit, it doesn't
need to failover",
+ taskSubmitTime,
Review Comment:
done, please review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
