kezhenxu94 commented on issue #13987: URL: https://github.com/apache/dolphinscheduler/issues/13987#issuecomment-1522953127
> > Looking forward your contribution, when change dependence, you should also change the license related file. Such as in > > https://github.com/apache/dolphinscheduler/blob/119f08d2bafd7d280dd9d323dae21ead2e08147f/dolphinscheduler-dist/release-docs/LICENSE#L576 > > > > https://github.com/apache/dolphinscheduler/blob/119f08d2bafd7d280dd9d323dae21ead2e08147f/dolphinscheduler-dist/release-docs/LICENSE#L585 > > > > it is better to search all project files > > One solution is to properly configure the dependencies of the master module pom file, and another solution is to use the shade plugin. I think the shade plugin can avoid potential dependency issues in the future. If it's possible to unify the versions of the dependencies (not only grpc ones), we should do that, shade plugin should be the last resort to consider as it hide the dependencies (and the licenses can not be automatically dealt with) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
