zhongjiajie commented on code in PR #14097:
URL:
https://github.com/apache/dolphinscheduler/pull/14097#discussion_r1193259655
##########
dolphinscheduler-storage-plugin/dolphinscheduler-storage-gcs/src/main/java/org/apache/dolphinscheduler/plugin/storage/gcs/GcsStorageOperator.java:
##########
@@ -122,16 +122,17 @@ public String getUdfDir(String tenantCode) {
}
@Override
- public String getResourceFileName(String tenantCode, String fileName) {
+ public String getResourceFullName(String tenantCode, String fileName) {
if (fileName.startsWith(FOLDER_SEPARATOR)) {
fileName.replaceFirst(FOLDER_SEPARATOR, EMPTY_STRING);
}
return String.format(FORMAT_S_S, getGcsResDir(tenantCode), fileName);
}
@Override
- public String getResourceFileName(String fullName) {
- return null;
+ public String getResourceFileName(String tenantCode, String fullName) {
+ String resDir = getResDir(tenantCode);
+ return fullName.replaceFirst(resDir, "");
Review Comment:
other LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
