calvinjiang commented on code in PR #14099:
URL:
https://github.com/apache/dolphinscheduler/pull/14099#discussion_r1194504979
##########
docs/docs/en/guide/parameter/built-in.md:
##########
@@ -2,11 +2,17 @@
## Basic Built-in Parameter
-| Variable | Declaration Method |
Meaning |
-|--------------------|-------------------------|---------------------------------------------------------------------------------------------|
-| system.biz.date | `${system.biz.date}` | The day before the schedule
time of the daily scheduling instance, the format is `yyyyMMdd` |
-| system.biz.curdate | `${system.biz.curdate}` | The schedule time of the
daily scheduling instance, the format is `yyyyMMdd` |
-| system.datetime | `${system.datetime}` | The schedule time of the
daily scheduling instance, the format is `yyyyMMddHHmmss` |
+| Variable | Declaration Method |
Meaning
|
+|---------------------------------|--------------------------------------|---------------------------------------------------------------------------------------------|
+| system.biz.date | `${system.biz.date}` | The
day before the schedule time of the daily scheduling instance, the format is
`yyyyMMdd` |
+| system.biz.curdate | `${system.biz.curdate}` | The
schedule time of the daily scheduling instance, the format is `yyyyMMdd`
|
+| system.datetime | `${system.datetime}` | The
schedule time of the daily scheduling instance, the format is `yyyyMMddHHmmss`
|
+| system.task.execute.path | `${system.task.execute.path}` | the
absolute path of current executing task
|
Review Comment:
the -> The is same as above.
##########
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/expand/CuringGlobalParams.java:
##########
@@ -206,6 +206,28 @@ public Map<String, Property>
paramParsingPreparation(@NonNull TaskInstance taskI
return globalParams;
}
+ /**
+ * build all built-in parameters
+ * @param taskInstance
+ * @param timeZone
+ */
+ private Map<String, String> setBuildInParamsMap(@NonNull TaskInstance
taskInstance,
Review Comment:
In my opinion you should change the function name from setBuildInParamsMap
to setBuiltInParamsMap.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
