This is an automated email from the ASF dual-hosted git repository.

kerwin pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/dolphinscheduler.git


The following commit(s) were added to refs/heads/dev by this push:
     new c6512edc3a revert [fix-#13956] [Master]taskId is null cause NPE #13980 
(#14142)
c6512edc3a is described below

commit c6512edc3a51ca5a9184c580b7fea33a2df79f1e
Author: Kerwin <[email protected]>
AuthorDate: Thu May 18 19:28:27 2023 +0800

    revert [fix-#13956] [Master]taskId is null cause NPE #13980 (#14142)
---
 .../dolphinscheduler/server/master/runner/WorkflowExecuteRunnable.java  | 2 --
 1 file changed, 2 deletions(-)

diff --git 
a/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteRunnable.java
 
b/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteRunnable.java
index 4cab7ea0b0..2837404102 100644
--- 
a/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteRunnable.java
+++ 
b/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteRunnable.java
@@ -1913,8 +1913,6 @@ public class WorkflowExecuteRunnable implements 
Callable<WorkflowSubmitStatus> {
             if (DependResult.SUCCESS == dependResult) {
                 log.info("The dependResult of task {} is success, so ready to 
submit to execute", task.getName());
                 if (!executeTask(task)) {
-                    // todo: don't ste 0 here
-                    task.setId(0);
                     this.taskFailedSubmit = true;
                     // Remove and add to complete map and error map
                     if (!removeTaskFromStandbyList(task)) {

Reply via email to