zhongjiajie commented on code in PR #14099:
URL:
https://github.com/apache/dolphinscheduler/pull/14099#discussion_r1203288755
##########
docs/docs/zh/guide/parameter/built-in.md:
##########
@@ -19,6 +19,36 @@
<td>${system.datetime}</td>
<td>日常调度实例定时的定时时间，格式为 yyyyMMddHHmmss</td>
</tr>
+ <tr>
Review Comment:
can you change this html table format to markdown one, just like you change
in English version
##########
docs/docs/en/guide/parameter/built-in.md:
##########
@@ -2,11 +2,17 @@
## Basic Built-in Parameter
-| Variable | Declaration Method |
Meaning |
-|--------------------|-------------------------|---------------------------------------------------------------------------------------------|
-| system.biz.date | `${system.biz.date}` | The day before the schedule
time of the daily scheduling instance, the format is `yyyyMMdd` |
-| system.biz.curdate | `${system.biz.curdate}` | The schedule time of the
daily scheduling instance, the format is `yyyyMMdd` |
-| system.datetime | `${system.datetime}` | The schedule time of the
daily scheduling instance, the format is `yyyyMMddHHmmss` |
+| Variable | Declaration Method |
Meaning
|
+|---------------------------------|--------------------------------------|---------------------------------------------------------------------------------------------|
+| system.biz.date | `${system.biz.date}` | The
day before the schedule time of the daily scheduling instance, the format is
`yyyyMMdd` |
+| system.biz.curdate | `${system.biz.curdate}` | The
schedule time of the daily scheduling instance, the format is `yyyyMMdd`
|
+| system.datetime | `${system.datetime}` | The
schedule time of the daily scheduling instance, the format is `yyyyMMddHHmmss`
|
+| system.task.execute.path | `${system.task.execute.path}` | The
absolute path of current executing task
|
+| system.task.instance.id | `${ssystem.task.instance.id}` | The
instance id of current task
|
+| system.task.definition.name | `${system.task.definition.name}` | The
definition name of current task
|
+| system.workflow.instance.id | `${system.workflow.instance.id}` | The
instance id of the workflow to which current task belongs
|
+| system.workflow.definition.name | `${system.workflow.definition.name}` | The
definition name of the workflow to which current task belongs
|
+| system.project.name | `${system.project.name}` | The
name of the project to which current task belongs
|
Review Comment:
can we also add `system.project.code`, `system.workflow.definition.code`,
`system.task.definition.code` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
