morningman commented on a change in pull request #2015: add profile for segment
v2
URL: https://github.com/apache/incubator-doris/pull/2015#discussion_r336721823
##########
File path: be/src/olap/rowset/segment_v2/column_reader.cpp
##########
@@ -227,7 +244,8 @@ void ColumnReader::_calculate_row_ranges(const
std::vector<uint32_t>& page_index
Status ColumnReader::_init_ordinal_index() {
PagePointer pp = _meta.ordinal_index_page();
PageHandle ph;
- RETURN_IF_ERROR(read_page(pp, &ph));
+ OlapReaderStatistics stats;
Review comment:
You define a OlapReaderStatistics on stack, and it will be destroyed after
`_init_ordinal_index()`, not passing it out.
I don't know what it is for?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
