wangbo commented on a change in pull request #2075: Segment v2 stream load core
dump(#2037)
URL: https://github.com/apache/incubator-doris/pull/2075#discussion_r339881832
##########
File path: be/src/olap/rowset/segment_v2/page_builder.h
##########
@@ -79,6 +84,12 @@ class PageBuilder {
// and should be followed by reset() before reuse the builder
virtual void release() = 0;
+ // Return a Slice which represents the encoded data of current page,and
release the slice
+ // caller need to delete the returned slice
+ virtual Slice finish_and_release() {
Review comment:
In some situation, caller just copy the page returned by PageBuilder, so
there is no need for caller to release the page,Such as in
BinaryDictPageBuilder.finish,BinaryDictPageBuilder's _data_page_builder just
return data page is ok,because BinaryDictPageBuilder just copy the page and
won't maintain the page
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
