imay commented on a change in pull request #2293: Support Grouping Sets, Rollup
and Cube to extend group by statement
URL: https://github.com/apache/incubator-doris/pull/2293#discussion_r352284358
##########
File path: fe/src/main/java/org/apache/doris/analysis/Expr.java
##########
@@ -965,10 +967,13 @@ public boolean equals(Object obj) {
@Override
public int hashCode() {
if (id == null) {
- throw new UnsupportedOperationException("Expr.hashCode() is not
implemented");
- } else {
- return id.asInt();
+ int result = 31 * Objects.hashCode(type) +
Objects.hashCode(opcode);
Review comment:
Please comment when this will be used when id is null
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
