imay commented on a change in pull request #2422: Add copy_object() method for
HLL columns when loading
URL: https://github.com/apache/incubator-doris/pull/2422#discussion_r356352788
##########
File path: be/src/olap/field.h
##########
@@ -161,6 +161,19 @@ class Field {
return _type_info->direct_copy(dst->mutable_cell_ptr(),
src.cell_ptr());
}
+ // deep copy source cell' content to destination cell.
+ // For string type, this will allocate data form pool,
+ // and copy srouce's conetent.
+ template<typename DstCellType, typename SrcCellType>
+ void copy_object(DstCellType* dst, const SrcCellType& src, MemPool* pool)
const {
Review comment:
If the template is not necessary, we can implement this in this file other
than change TypeInfo.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
