imay commented on a change in pull request #2343: [Tag System]Add classes related to "tag". URL: https://github.com/apache/incubator-doris/pull/2343#discussion_r357517541
########## File path: fe/src/main/java/org/apache/doris/resource/Resource.java ########## @@ -0,0 +1,73 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.resource; + +import org.apache.doris.common.io.Writable; + +import java.io.DataInput; +import java.io.DataOutput; +import java.io.IOException; + +/* + * Resource is the collective name of the nodes that provide various service capabilities in Doris cluster. + * Each resource has a unique ID. + * A resource may have one or more tags that represent the functional properties or custom groupings of a resource, etc. + * eg: + * Backend, Frontend, Broker, RemoteStorage + */ +public abstract class Resource implements Writable { + protected long id; + protected TagSet tagSet; + + public Resource(long id, TagSet tagSet) { + this.tagSet = tagSet; + } + + public long getId() { + return id; + } + + public TagSet getTagSet() { + return tagSet; + } + + public void addTag(Tag.Type type, String tagName) { + Tag tag = Tag.create(type, tagName); + tagSet.addTag(tag); + } + + public void setTag(Tag.Type type, String tagName) { + TagSet newTagSet = TagSet.create(Tag.create(type, tagName)); + tagSet.substituteMerge(newTagSet); + } + + public void setTagSet(TagSet tagSet) { + this.tagSet = tagSet; + } + + @Override + public void write(DataOutput out) throws IOException { + out.writeLong(id); + tagSet.write(out); Review comment: Use new method of serialization? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
