imay commented on a change in pull request #3271: [Bug] Avoid compacting
recently added rowset
URL: https://github.com/apache/incubator-doris/pull/3271#discussion_r404785994
##########
File path: be/src/olap/rowset/rowset.cpp
##########
@@ -65,6 +67,9 @@ void Rowset::make_visible(Version version, VersionHash
version_hash) {
_rowset_meta->set_version(version);
_rowset_meta->set_version_hash(version_hash);
_rowset_meta->set_rowset_state(VISIBLE);
+ // update create time to the visible time,
+ // it's used to skip recently published version during compaction
+ _rowset_meta->set_creation_time(time(nullptr));
Review comment:
Just to unify. I think it will be better to use functions in this file to
get all kinds of current time.
Actually, it is OK for this case to get a monotonic time other than wall
time, which will still work when system time rollback.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
