github-actions[bot] commented on code in PR #19116:
URL: https://github.com/apache/doris/pull/19116#discussion_r1177953906
##########
be/src/geo/wkb_parse.h:
##########
@@ -41,14 +41,14 @@
static WkbParseContext* read(std::istream& is, WkbParseContext* ctx);
- static GeoShape* readGeometry(WkbParseContext* ctx);
+ static std::unique_ptr<GeoShape> readGeometry(WkbParseContext* ctx);
private:
- static GeoPoint* readPoint(WkbParseContext* ctx);
+ static std::unique_ptr<GeoPoint> readPoint(WkbParseContext* ctx);
Review Comment:
warning: no template named 'unique_ptr' in namespace 'std'
[clang-diagnostic-error]
```cpp
static std::unique_ptr<GeoPoint> readPoint(WkbParseContext* ctx);
^
```
##########
be/src/geo/wkb_parse.h:
##########
@@ -41,14 +41,14 @@ class WkbParse {
static WkbParseContext* read(std::istream& is, WkbParseContext* ctx);
- static GeoShape* readGeometry(WkbParseContext* ctx);
+ static std::unique_ptr<GeoShape> readGeometry(WkbParseContext* ctx);
Review Comment:
warning: no template named 'unique_ptr' in namespace 'std'
[clang-diagnostic-error]
```cpp
static std::unique_ptr<GeoShape> readGeometry(WkbParseContext* ctx);
^
```
##########
be/src/geo/wkb_parse.h:
##########
@@ -41,14 +41,14 @@
static WkbParseContext* read(std::istream& is, WkbParseContext* ctx);
- static GeoShape* readGeometry(WkbParseContext* ctx);
+ static std::unique_ptr<GeoShape> readGeometry(WkbParseContext* ctx);
private:
- static GeoPoint* readPoint(WkbParseContext* ctx);
+ static std::unique_ptr<GeoPoint> readPoint(WkbParseContext* ctx);
- static GeoLine* readLine(WkbParseContext* ctx);
+ static std::unique_ptr<GeoLine> readLine(WkbParseContext* ctx);
- static GeoPolygon* readPolygon(WkbParseContext* ctx);
+ static std::unique_ptr<GeoPolygon> readPolygon(WkbParseContext* ctx);
Review Comment:
warning: no template named 'unique_ptr' in namespace 'std'
[clang-diagnostic-error]
```cpp
static std::unique_ptr<GeoPolygon> readPolygon(WkbParseContext* ctx);
^
```
##########
be/src/geo/wkb_parse.h:
##########
@@ -41,14 +41,14 @@
static WkbParseContext* read(std::istream& is, WkbParseContext* ctx);
- static GeoShape* readGeometry(WkbParseContext* ctx);
+ static std::unique_ptr<GeoShape> readGeometry(WkbParseContext* ctx);
private:
- static GeoPoint* readPoint(WkbParseContext* ctx);
+ static std::unique_ptr<GeoPoint> readPoint(WkbParseContext* ctx);
- static GeoLine* readLine(WkbParseContext* ctx);
+ static std::unique_ptr<GeoLine> readLine(WkbParseContext* ctx);
Review Comment:
warning: no template named 'unique_ptr' in namespace 'std'
[clang-diagnostic-error]
```cpp
static std::unique_ptr<GeoLine> readLine(WkbParseContext* ctx);
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
