Bingandbing commented on code in PR #18747:
URL: https://github.com/apache/doris/pull/18747#discussion_r1178794793
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/physical/AbstractPhysicalJoin.java:
##########
@@ -183,4 +184,17 @@ public Optional<MarkJoinSlotReference>
getMarkJoinSlotReference() {
public void addFilterConjuncts(Collection<Expression> conjuncts) {
filterConjuncts.addAll(conjuncts);
}
+
+ @Override
+ public JSONObject toJson() {
Review Comment:
Because abstractPhysicalJoin can be different with abstractLogicalJoin, so
her can have some different implementation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
