CodeCooker17 commented on code in PR #19265:
URL: https://github.com/apache/doris/pull/19265#discussion_r1185642283
##########
fe/fe-common/src/test/java/org/apache/doris/common/property/PropertySchemaTest.java:
##########
@@ -244,8 +246,8 @@ public void testDatePropInvalidString() {
exceptionRule.expect(IllegalArgumentException.class);
exceptionRule.expectMessage(Matchers.containsString("Invalid time
format"));
- PropertySchema.DateProperty prop = new
PropertySchema.DateProperty("key", new SimpleDateFormat("yyyy-MM-dd "
- + "HH:mm:ss"));
+ PropertySchema.DateProperty prop = new
PropertySchema.DateProperty("key", DateTimeFormatter.ofPattern("yyyy-MM-dd "
+ + "HH:mm:ss").withZone(ZoneId.systemDefault()));
Review Comment:
@morningman ok, i will improve code style and solve these problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
