lvshaokang commented on code in PR #19142:
URL: https://github.com/apache/doris/pull/19142#discussion_r1185786640
##########
fe/fe-core/src/main/java/org/apache/doris/load/loadv2/LoadManager.java:
##########
@@ -871,4 +873,43 @@ public void readFields(DataInput in) throws IOException {
}
}
}
+
+ // ------------------------ for load refactor ------------------------
+ public long createLoadJobFromStmt(InsertStmt insertStmt) throws
DdlException {
Review Comment:
Is this method only used the BulkLoad type? If right, use
`createBulkLoadJobFromStmt` may be more clearly.
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/UnifiedLoadStmt.java:
##########
@@ -0,0 +1,61 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.analysis;
+
+import org.apache.doris.qe.ConnectContext;
+
+import com.google.common.base.Preconditions;
+
+import java.util.List;
+import java.util.Map;
+
+/**
+ * Used for load refactor, as an adapter for original load stmt, will proxy to
insert stmt or original load stmt, chosen
+ * by configuration
+ */
+public class UnifiedLoadStmt extends DdlStmt {
+
+ private final StatementBase proxyStmt;
+
+ public UnifiedLoadStmt(LabelName label, List<DataDescription>
dataDescriptions,
+ BrokerDesc brokerDesc, String cluster, Map<String, String>
properties, String comment, LoadType loadType) {
+ final ConnectContext connectContext = ConnectContext.get();
+ if (connectContext != null &&
connectContext.getSessionVariable().isEnableUnifiedLoad()) {
+ switch (loadType) {
+ case BROKER_LOAD:
+ proxyStmt = new BrokerLoadStmt(label, dataDescriptions,
brokerDesc, properties, comment);
+ break;
+ case MYSQL_LOAD:
Review Comment:
Is it redundant here? As I understand it, mysql load does not have
properties such as label, broker desc, etc. Now, loadType use the hard code to
defined. Whether it is better to create the new constructor method to handle
LoadStmt?
##########
fe/fe-core/src/main/cup/sql_parser.cup:
##########
@@ -2321,7 +2322,7 @@ load_stmt ::=
opt_properties:properties
opt_comment:comment
{:
- RESULT = new LoadStmt(label, dataDescList, broker, system, properties,
comment);
+ RESULT = new UnifiedLoadStmt(label, dataDescList, broker, system,
properties, comment, LoadType.BROKER_LOAD);
Review Comment:
I can see, the UnifiedLoadStmt is unified as a entry point for the broker
load, which defines the load type using hard coding. For the `mysql load `, I
same need create the UnifiedLoadStmt contruct method to unified at the
line[1], right?
[1]
https://github.com/apache/doris/blob/master/fe/fe-core/src/main/cup/sql_parser.cup#L2340
##########
fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java:
##########
@@ -629,7 +644,7 @@ public void executeByLegacy(TUniqueId queryId) throws
Exception {
if (!context.isTxnModel()) {
Span queryAnalysisSpan =
context.getTracer().spanBuilder("query
analysis").setParent(Context.current()).startSpan();
- try (Scope scope = queryAnalysisSpan.makeCurrent()) {
+ try (Scope ignored = queryAnalysisSpan.makeCurrent()) {
Review Comment:
if not used, suggest `try (queryAnalysisSpan.makeCurrent()) { `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
