TangSiyang2001 commented on code in PR #19142:
URL: https://github.com/apache/doris/pull/19142#discussion_r1185859492
##########
fe/fe-core/src/main/java/org/apache/doris/load/loadv2/LoadManager.java:
##########
@@ -871,4 +873,43 @@ public void readFields(DataInput in) throws IOException {
}
}
}
+
+ // ------------------------ for load refactor ------------------------
+ public long createLoadJobFromStmt(InsertStmt insertStmt) throws
DdlException {
Review Comment:
It is a preparation for the next part of refactor, I plan to use the unified
entrance to create Job from stmt. This method will also create other kinds of
load job in the later refactor. And a heavy refactor will happend to
LoadManager.
Currently, implementation for other kinds of load may just reuse the
temporary class LoadManagerAdapter to make integration to the corresponding
load.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
