yiguolei commented on code in PR #19303:
URL: https://github.com/apache/doris/pull/19303#discussion_r1186574943
##########
be/src/olap/cumulative_compaction.cpp:
##########
@@ -117,7 +117,7 @@ Status CumulativeCompaction::pick_rowsets_to_compact() {
// candidate_rowsets may not be continuous
// So we need to choose the longest continuous path from it.
std::vector<Version> missing_versions;
- RETURN_NOT_OK(find_longest_consecutive_version(&candidate_rowsets,
&missing_versions));
+ OLAP_RETURN_NOT_OK(find_longest_consecutive_version(&candidate_rowsets,
&missing_versions));
Review Comment:
Do not add this new macro OLAP_RETURN_NOT_OK. If RETURN_NOT_OK is conflict
with arrow's macro definition. You could remove this macro "RETURN_NOT_OK"
totally and use RETURN_IF_ERROR instead. They are same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
