morningman commented on a change in pull request #3418: URL: https://github.com/apache/incubator-doris/pull/3418#discussion_r429094156
########## File path: fe/src/main/java/org/apache/doris/catalog/ResourceMgr.java ########## @@ -0,0 +1,189 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.catalog; + +import org.apache.doris.analysis.CreateResourceStmt; +import org.apache.doris.analysis.DropResourceStmt; +import org.apache.doris.catalog.Resource.ResourceType; +import org.apache.doris.common.DdlException; +import org.apache.doris.common.io.Writable; +import org.apache.doris.common.proc.BaseProcResult; +import org.apache.doris.common.proc.ProcNodeInterface; +import org.apache.doris.common.proc.ProcResult; +import org.apache.doris.mysql.privilege.PrivPredicate; +import org.apache.doris.qe.ConnectContext; + +import com.google.common.collect.ImmutableList; +import com.google.common.collect.Maps; +import org.apache.logging.log4j.LogManager; +import org.apache.logging.log4j.Logger; + +import java.io.DataInput; +import java.io.DataOutput; +import java.io.IOException; +import java.util.List; +import java.util.Map; +import java.util.concurrent.locks.ReentrantLock; + +/** + * Resource manager is responsible for managing external resources used by Doris. + * For example, Spark/MapReduce used for ETL, Spark/GPU used for queries, HDFS/S3 used for external storage. + * Now only support Spark. + */ +public class ResourceMgr implements Writable { + private static final Logger LOG = LogManager.getLogger(ResourceMgr.class); + + public static final ImmutableList<String> RESOURCE_PROC_NODE_TITLE_NAMES = new ImmutableList.Builder<String>() + .add("Name").add("ResourceType").add("Key").add("Value") + .build(); + + // { resourceName -> Resource} + private final Map<String, Resource> nameToResource = Maps.newHashMap(); + private final ReentrantLock lock = new ReentrantLock(); + private final ResourceProcNode procNode = new ResourceProcNode(); + + public ResourceMgr() { + } + + public void createResource(CreateResourceStmt stmt) throws DdlException { + lock.lock(); + try { + if (stmt.getResourceType() != ResourceType.SPARK) { + throw new DdlException("Only support Spark resource."); + } + + String resourceName = stmt.getResourceName(); + if (nameToResource.containsKey(resourceName)) { + throw new DdlException("Resource(" + resourceName + ") already exist"); + } + + Resource resource = Resource.fromStmt(stmt); + nameToResource.put(resourceName, resource); + // log add + Catalog.getInstance().getEditLog().logCreateResource(resource); + LOG.info("create resource success. resource: {}", resource); + } finally { + lock.unlock(); + } + } + + public void replayCreateResource(Resource resource) { + lock.lock(); + try { + nameToResource.put(resource.getName(), resource); + } finally { + lock.unlock(); + } + } + + public void dropResource(DropResourceStmt stmt) throws DdlException { + lock.lock(); + try { + String name = stmt.getResourceName(); + if (!nameToResource.containsKey(name)) { + throw new DdlException("Resource(" + name + ") does not exist"); + } + + nameToResource.remove(name); + // log drop + Catalog.getInstance().getEditLog().logDropResource(name); + LOG.info("drop resource success. resource name: {}", name); + } finally { + lock.unlock(); + } + } + + public void replayDropResource(String name) { + lock.lock(); + try { + nameToResource.remove(name); + } finally { + lock.unlock(); + } + } + + public boolean containsResource(String name) { + lock.lock(); + try { + return nameToResource.containsKey(name); + } finally { + lock.unlock(); + } + } + + public Resource getResource(String name) { + lock.lock(); + try { + return nameToResource.get(name); + } finally { + lock.unlock(); + } + } + + public int getResourceNum() { + return nameToResource.size(); + } + + public List<List<String>> getResourcesInfo() { + return procNode.fetchResult().getRows(); + } + + public ResourceProcNode getProcNode() { + return procNode; + } + + @Override + public void write(DataOutput out) throws IOException { + out.writeInt(nameToResource.size()); Review comment: use Gson instead. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
