TangSiyang2001 commented on code in PR #19392:
URL: https://github.com/apache/doris/pull/19392#discussion_r1187356884
##########
fe/fe-core/src/main/java/org/apache/doris/load/loadv2/BrokerLoadJob.java:
##########
@@ -387,4 +389,9 @@ public void afterVisible(TransactionState txnState, boolean
txnOperated) {
super.afterVisible(txnState, txnOperated);
writeProfile();
}
+
+ @Override
+ protected String getResourceName() {
+ return cluster != null ? cluster : "N/A";
+ }
Review Comment:
And another way that I think may be tricky is to imitate SparkLoadJob that
we just use the broker name(BroekrDesc#getName) as `cluster`. What's ur
opinion? Personally I will recommend this way because there's less changes and
will not make cluster become "N/A" which seems a little wierd.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
