kaka11chen commented on code in PR #19518:
URL: https://github.com/apache/doris/pull/19518#discussion_r1190585850
##########
be/src/vec/exec/format/orc/vorc_reader.cpp:
##########
@@ -284,6 +301,44 @@ Status OrcReader::_init_read_columns() {
return Status::OK();
}
+void OrcReader::_init_orc_cols(const orc::Type& type,
std::vector<std::string>& orc_cols,
+ std::vector<std::string>& orc_cols_lower_case) {
+ for (int i = 0; i < type.getSubtypeCount(); ++i) {
+ orc_cols.emplace_back(type.getFieldName(i));
+ orc_cols_lower_case.emplace_back(_get_field_name_lower_case(&type, i));
+ const orc::Type* sub_type = type.getSubtype(i);
+ if (sub_type->getKind() == orc::TypeKind::STRUCT) {
+ _init_orc_cols(*sub_type, orc_cols, orc_cols_lower_case);
+ }
+ }
+}
+
+bool OrcReader::_check_acid_schema(const orc::Type& type) {
Review Comment:
Good idea. It will be improved in the full acid implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
