imay commented on a change in pull request #3705:
URL: https://github.com/apache/incubator-doris/pull/3705#discussion_r431540575
##########
File path: fe/src/main/java/org/apache/doris/alter/SchemaChangeJobV2.java
##########
@@ -1081,14 +969,8 @@ private void readJobFinishedData(DataInput in) throws
IOException {
@Override
public void write(DataOutput out) throws IOException {
- super.write(out);
-
- out.writeBoolean(isMetaPruned);
- if (isMetaPruned) {
- writeJobFinishedData(out);
- } else {
- writeJobNotFinishData(out);
- }
+ String json = GsonUtils.GSON.toJson(this, AlterJobV2.class);
Review comment:
write don't match with readFields
##########
File path: fe/src/main/java/org/apache/doris/alter/RollupJobV2.java
##########
@@ -770,4 +714,85 @@ public void setJobState(JobState jobState) {
this.jobState = jobState;
}
+ private void setColumnsDefineExpr(List<MVColumnItem> items) {
+ for (MVColumnItem item : items) {
+ for (Column column : rollupSchema) {
+ if (column.getName().equals(item.getName())) {
+ column.setDefineExpr(item.getDefineExpr());
+ break;
+ }
+ }
+ }
+ }
+
+ @Override
+ public void write(DataOutput out) throws IOException {
+ String json = GsonUtils.GSON.toJson(this, AlterJobV2.class);
+ Text.writeString(out, json);
+ }
+
+ public static RollupJobV2 read(DataInput in) throws IOException {
Review comment:
This is not match with what `write` writes. We should make them
consistent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
