wutiangan commented on a change in pull request #3527:
URL: https://github.com/apache/incubator-doris/pull/3527#discussion_r431580310



##########
File path: fe/src/main/java/org/apache/doris/analysis/BinaryPredicate.java
##########
@@ -306,6 +300,10 @@ private Type getCmpType() {
             return Type.LARGEINT;
         }
 
+        if ((t1.isNumericType() && t2.isStringType()) || (t1.isStringType() && 
t2.isNumericType())) {
+            return t1.isNumericType() ? Type.fromPrimitiveType(t1) : 
Type.fromPrimitiveType(t2);
+        }

Review comment:
       Can you explain in detail if both input parameters are decimal type., 
why this funciton return decimal type?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to