Yukang-Lian commented on code in PR #19571:
URL: https://github.com/apache/doris/pull/19571#discussion_r1193276178
##########
fe/fe-core/src/main/java/org/apache/doris/load/loadv2/LoadManagerAdapter.java:
##########
@@ -31,15 +37,25 @@
*/
public class LoadManagerAdapter {
- public void startLoadFromInsertStmt(InsertStmt insertStmt) throws
DdlException {
+ private String mysqlLoadId;
+
+ public void submitLoadFromInsertStmt(ConnectContext context, InsertStmt
insertStmt)
+ throws UserException, IOException {
final LoadType loadType = insertStmt.getLoadType();
final LoadManager loadManager = Env.getCurrentEnv().getLoadManager();
switch (loadType) {
case BROKER_LOAD:
loadManager.createLoadJobFromStmt(insertStmt);
+ context.getState().setOk();
break;
case MYSQL_LOAD:
// TODO: implement
Review Comment:
useless code
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/InsertStmt.java:
##########
@@ -117,7 +117,7 @@ public static class Properties {
// ---------------------------- for old insert stmt
----------------------------
public boolean isValuesOrConstantSelect() {
- throw new UnsupportedOperationException("only invoked in
NativeInsertStmt");
+ return false;
Review Comment:
why change this?
##########
fe/fe-core/src/main/java/org/apache/doris/load/loadv2/MysqlLoadManager.java:
##########
@@ -148,9 +149,13 @@ public MysqlLoadManager(TokenManager tokenManager) {
public LoadJobRowResult executeMySqlLoadJobFromStmt(ConnectContext
context, LoadStmt stmt, String loadId)
throws IOException, UserException {
+ return executeMySqlLoadJobFromStmt(context,
stmt.getDataDescriptions().get(0), loadId);
+ }
+
+ public LoadJobRowResult executeMySqlLoadJobFromStmt(ConnectContext
context, DataDescription dataDesc, String loadId)
+ throws IOException, UserException {
LoadJobRowResult loadResult = new LoadJobRowResult();
// Mysql data load only have one data desc
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
