WingsGo commented on a change in pull request #3713:
URL: https://github.com/apache/incubator-doris/pull/3713#discussion_r431702383
##########
File path: fe/src/main/java/org/apache/doris/master/ReportHandler.java
##########
@@ -247,6 +249,13 @@ private static void tabletReport(long backendId, Map<Long,
TTablet> backendTable
LOG.info("backend[{}] reports {} tablet(s). report version: {}",
backendId, backendTablets.size(), backendReportVersion);
+ final SystemInfoService currentSystemInfo =
Catalog.getCurrentSystemInfo();
+ Backend reportBackend = currentSystemInfo.getBackend(backendId);
+ if (reportBackend != null) {
+ BackendStatus backendStatus = reportBackend.getBackendStatus();
+ backendStatus.lastTabletReportTime =
TimeUtils.longToTimeString(start);
Review comment:
if we need add more info, we can just add a new Field in `BackendStatus`
and set the field's value, and new info will be shown in `show backends`, why
we need to set the value and update the value?I think we can just set the
value, and the new value will be shown when we use `show backends`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
