morningman commented on code in PR #19947:
URL: https://github.com/apache/doris/pull/19947#discussion_r1204906499
##########
be/src/io/fs/buffered_reader.cpp:
##########
@@ -410,6 +411,13 @@ void PrefetchBuffer::prefetch_buffer() {
SCOPED_RAW_TIMER(&_statis.read_time);
s = _reader->read_at(_offset, Slice {_buf.get(), buf_size}, &_len,
_io_ctx);
}
+ if (UNLIKELY(buf_size != _len)) {
+ // This indicates that the data size returned by S3 object storage is
smaller than what we requested,
+ // which seems to be a violation of the S3 protocol since our request
range was valid.
+ // We currently consider this situation a bug and will treat this task
as a failure.
+ s = Status::InternalError("Data size returned by S3 is smaller than
requested");
Review Comment:
Print details? like buf_size and _len
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]