eldenmoon commented on code in PR #19594:
URL: https://github.com/apache/doris/pull/19594#discussion_r1209688779
##########
be/src/olap/rowset/segment_v2/segment_writer.cpp:
##########
@@ -113,38 +116,29 @@ void SegmentWriter::init_column_meta(ColumnMetaPB* meta,
uint32_t column_id,
}
}
-Status SegmentWriter::init(const vectorized::Block* block) {
+Status SegmentWriter::init(const FlushContext* flush_ctx) {
std::vector<uint32_t> column_ids;
int column_cnt = _tablet_schema->num_columns();
- if (block && !_tablet_schema->is_partial_update()) {
Review Comment:
the code is wrong, i have discussed with @yixiutt and the code could be
delete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
