yiguolei commented on code in PR #20456:
URL: https://github.com/apache/doris/pull/20456#discussion_r1218814082
##########
be/src/olap/rowset/segment_v2/column_reader.cpp:
##########
@@ -220,7 +225,8 @@ Status ColumnReader::init() {
}
Status ColumnReader::new_bitmap_index_iterator(BitmapIndexIterator** iterator)
{
- RETURN_IF_ERROR(_ensure_index_loaded());
+ bool use_page_cache = !config::disable_storage_page_cache &&
_index_meta_use_page_cache;
Review Comment:
could we add a private class member use_page_cache? Then we could just use
the class member at line 229.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
