yiguolei commented on code in PR #20742:
URL: https://github.com/apache/doris/pull/20742#discussion_r1227711232
##########
be/src/exprs/runtime_filter_slots.h:
##########
@@ -220,7 +220,11 @@ class RuntimeFilterSlotsBase {
Status publish() {
for (auto& pair : _runtime_filters) {
for (auto filter : pair.second) {
- RETURN_IF_ERROR(filter->publish());
+ auto state = filter->publish();
+ if (!state) {
+ // TODO: solve publish failed when scan not schedured
+ LOG(WARNING) << "filter publish failed, reason=" <<
state.to_string();
Review Comment:
If state is not ok, why not return error status?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
