yiguolei commented on code in PR #20732:
URL: https://github.com/apache/doris/pull/20732#discussion_r1227964752
##########
be/src/service/internal_service.cpp:
##########
@@ -1512,11 +1512,18 @@ Status PInternalServiceImpl::_multi_get(const
PMultiGetRequest& request,
if (!tablet) {
continue;
}
+ // Get Rowset from either tablet or unused rowsets, since this rowset
maybe expired and swept.
+ // But we ensured it's rowset is not released when init Tablet reader
param, by QueryContext::hold_reference
BetaRowsetSharedPtr rowset =
std::static_pointer_cast<BetaRowset>(tablet->get_rowset(rowset_id));
if (!rowset) {
- LOG(INFO) << "no such rowset " << rowset_id;
- continue;
+ std::optional<RowsetSharedPtr> from_unused_rowset =
Review Comment:
If it is hold in query context, why not get it from query context?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
