platoneko commented on code in PR #20715:
URL: https://github.com/apache/doris/pull/20715#discussion_r1229032359
##########
be/src/olap/tablet.cpp:
##########
@@ -1062,10 +1063,18 @@ uint32_t Tablet::_calc_base_compaction_score() const {
// all_rs_metas() is not sorted, so we use _continue_ other than
_break_ here.
continue;
}
-
+ if (rs_meta->has_delete_predicate()) {
+ has_delete = true;
+ }
score += rs_meta->get_compaction_score();
}
+ // In the time series compaction policy, we want the base compaction to be
triggered
+ // when there are delete versions present.
+ if (config::compaction_policy == std::string("time_series")) {
Review Comment:
```suggestion
if (config::compaction_policy == "time_series") {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
