TangSiyang2001 opened a new pull request, #20867:
URL: https://github.com/apache/doris/pull/20867

   ## Proposed changes
   
   Issue Number: close #xxx
   
   FloatLiteral will encounter loss of precision
   
   ```java
   private void init(Double value) {
           this.value = value.doubleValue();
           // Figure out if this will fit in a FLOAT without losing precision.
           float fvalue;
           fvalue = value.floatValue();
           if (fvalue == this.value) {
               // here use == to compare floating-point number, which will 
encounter loss of percision, and will get unexpected result
               type = Type.FLOAT;
           } else {
               type = Type.DOUBLE;
           }
       }
   ```
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[[email protected]](mailto:[email protected]) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to