AshinGau commented on code in PR #19990:
URL: https://github.com/apache/doris/pull/19990#discussion_r1232096103
##########
be/src/vec/exec/jni_connector.h:
##########
@@ -197,6 +216,17 @@ class JniConnector {
*/
Status get_nex_block(Block* block, size_t* read_rows, bool* eof);
+ /**
+ * Call java side function JniScanner.getTableSchema.
+ *
+ * The schema information are stored as a string.
+ * Use # between column names and column types.
+ *
+ * like: col_name1,col_name2,col_name3#col_type1,col_type2.col_type3
Review Comment:
There is an issue with the concatenation method of this string, as type may
contain commas, such as the decimal type. You can directly return Map<String,
String> type, as shown in the process of passing map types as parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
