TangSiyang2001 commented on code in PR #20694:
URL: https://github.com/apache/doris/pull/20694#discussion_r1232404881
##########
regression-test/suites/load_p0/insert/test_insert.groovy:
##########
@@ -48,4 +48,38 @@ suite("test_insert") {
"""
qt_sql1 "select * from ${insert_tbl} order by 1, 2, 3, 4"
+
+ def insert_tbl_dft = "test_insert_dft_tbl"
+ sql """ DROP TABLE IF EXISTS ${insert_tbl_dft}"""
+
+ // `k7` should be float type, and bug exists now,
https://github.com/apache/doris/pull/20867
+ // `k9` should be char(16), and bug exists now as error msg raised:"can
not cast from origin type TINYINT to target type=CHAR(16)" when doing insert
+ // "`k13` datetime default CURRENT_TIMESTAMP" might have cast error in
strict mode when doing insert:
+ // [INTERNAL_ERROR]Invalid value in strict mode for function CAST, source
column String, from type String to type DateTimeV2
Review Comment:
I got it, the default value here for `CURRENT_TIMESTAMP` is the string
itself, which is confirmed to be a bug.
Related logic for default val processing in NativeInsertStmt
https://github.com/apache/doris/blob/bf197ee8d2d9e6ccf88184663e4614068bc3edde/fe/fe-core/src/main/java/org/apache/doris/analysis/NativeInsertStmt.java#L661-L676
Maybe due to unreasonable logic here, so
`targetColumns.get(i).getDefaultValue())` returns the string itself.
https://github.com/apache/doris/blob/bf197ee8d2d9e6ccf88184663e4614068bc3edde/fe/fe-core/src/main/java/org/apache/doris/analysis/ColumnDef.java#L106-L109
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
