yiguolei commented on code in PR #21454:
URL: https://github.com/apache/doris/pull/21454#discussion_r1251381259
##########
be/src/common/status.h:
##########
@@ -351,19 +351,6 @@ class Status {
return status;
}
- template <int code, bool stacktrace = true>
- Status static Error() {
- Status status;
- status._code = code;
-#ifdef ENABLE_STACKTRACE
- if constexpr (stacktrace && capture_stacktrace<code>()) {
- status._err_msg = std::make_unique<ErrMsg>();
- status._err_msg->_stack = get_stack_trace();
- }
-#endif
- return status;
- }
-
template <typename... Args>
Status static Error(int code, std::string_view msg, Args&&... args) {
Status status;
Review Comment:
This error message lost stacktrace, maybe forget in previous PR.
#ifdef ENABLE_STACKTRACE
if constexpr (stacktrace && capture_stacktrace<code>()) {
status._err_msg->_stack = get_stack_trace();
}
#endif
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
