morningman commented on code in PR #21487:
URL: https://github.com/apache/doris/pull/21487#discussion_r1253278526
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/DefaultValueExprDef.java:
##########
@@ -23,28 +23,44 @@
import org.apache.doris.catalog.Type;
import org.apache.doris.common.AnalysisException;
+import com.google.common.collect.Lists;
import com.google.gson.annotations.SerializedName;
import org.apache.log4j.LogManager;
import org.apache.log4j.Logger;
+import java.util.List;
+
/**
* This def used for column which defaultValue is an expression.
*/
public class DefaultValueExprDef {
private static final Logger LOG =
LogManager.getLogger(DefaultValueExprDef.class);
@SerializedName("exprName")
private String exprName;
+ @SerializedName("precision")
+ private Long precision;
Review Comment:
For newly added field, better implement `GsonPostProcessable` and give it a
init value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
