liaoxin01 commented on code in PR #20907:
URL: https://github.com/apache/doris/pull/20907#discussion_r1253993465
##########
be/src/olap/txn_manager.cpp:
##########
@@ -632,6 +632,28 @@ void
TxnManager::get_all_related_tablets(std::set<TabletInfo>* tablet_infos) {
}
}
+void TxnManager::get_all_commit_tablet_txn_info_by_tablet(
Review Comment:
Just returning references to delete_bitmap and rowset_ids is enough?
##########
be/src/olap/tablet.cpp:
##########
@@ -3240,6 +3240,13 @@ Status Tablet::commit_phase_update_delete_bitmap(
<< ", rowset_ids to del: " << rowset_ids_to_del.size()
<< ", cur max_version: " << cur_version << ", transaction_id: "
<< txn_id
<< ", cost: " << watch.get_elapse_time_us() << "(us), total
rows: " << total_rows;
+
+ for (auto iter = delete_bitmap->delete_bitmap.begin();
Review Comment:
no need to do this conversion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
