amorynan opened a new pull request, #21699:
URL: https://github.com/apache/doris/pull/21699

   ## Proposed changes
   
   Issue Number: close #xxx
   1. when cal array hash, elem size is not need to seed hash 
   ```
   hash = HashUtil::zlib_crc_hash(reinterpret_cast<const char*>(&elem_size),
                                                      sizeof(elem_size), hash);
   ```
   but we need to be care [[], [1]] vs [[1], []], when array nested array , and 
nested array is empty, we should make hash seed to 
   make difference
   2.  use range for one hash value to avoid virtual function call in loop.
   which double the performance. I make it in ut
   
    column: array[int64]
     50 rows , and single array has 1000000 elements
   
   before : 
   <img width="797" alt="截屏2023-07-10 22 20 45" 
src="https://github.com/apache/doris/assets/18551114/25b70cb0-e407-4fff-b45e-d516527cdf34";>
   
   after : 
   <img width="680" alt="截屏2023-07-10 22 23 08" 
src="https://github.com/apache/doris/assets/18551114/5cb78933-2cbe-4cbc-9a9d-28bf7a76fcf4";>
   
   
   <!--Describe your changes.-->
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at 
[[email protected]](mailto:[email protected]) by explaining why you 
chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to