xinyiZzz commented on code in PR #21755:
URL: https://github.com/apache/doris/pull/21755#discussion_r1264307658
##########
be/CMakeLists.txt:
##########
@@ -251,6 +254,9 @@ set_target_properties(jemalloc PROPERTIES IMPORTED_LOCATION
${THIRDPARTY_DIR}/li
add_library(jemalloc_arrow STATIC IMPORTED)
set_target_properties(jemalloc_arrow PROPERTIES IMPORTED_LOCATION
${THIRDPARTY_DIR}/lib64/libjemalloc.a)
+add_library(libunwind STATIC IMPORTED)
Review Comment:
弄明白了，原因见这两个pr，当系统包含 libunwind 时，glog会自动寻找 libunwind
依赖项加载，如果通过yum将libunwind安装在/usr/lib下会导致编译错误
https://github.com/apache/doris/pull/7866
https://github.com/StarRocks/starrocks/pull/2093
所以这个pr没有直接 -lunwind 用系统依赖，在 thridparty 中增加 libunwind 手动加载，避免可能出现的类似问题
##########
be/CMakeLists.txt:
##########
@@ -251,6 +254,9 @@ set_target_properties(jemalloc PROPERTIES IMPORTED_LOCATION
${THIRDPARTY_DIR}/li
add_library(jemalloc_arrow STATIC IMPORTED)
set_target_properties(jemalloc_arrow PROPERTIES IMPORTED_LOCATION
${THIRDPARTY_DIR}/lib64/libjemalloc.a)
+add_library(libunwind STATIC IMPORTED)
Review Comment:
弄明白了，原因见这两个pr，当系统包含 libunwind 时，glog会自动寻找 libunwind
依赖项加载，如果通过yum将libunwind安装在/usr/lib下会导致编译错误
https://github.com/apache/doris/pull/7866
https://github.com/StarRocks/starrocks/pull/2093
所以这个pr没有直接 -lunwind 用系统依赖，在 thridparty 中增加 libunwind 手动加载，避免可能出现的类似问题
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
