morningman commented on code in PR #21941:
URL: https://github.com/apache/doris/pull/21941#discussion_r1266933205
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/external/HMSExternalDatabase.java:
##########
@@ -74,7 +74,17 @@ public void dropTable(String tableName) {
}
@Override
- public void replayCreateTableFromEvent(String tableName, long tableId) {
+ public void dropTableForReplay(String tableName) {
+ LOG.debug("replayDropTableFromEvent [{}]", tableName);
+ Long tableId = tableNameToId.remove(tableName);
+ if (tableId == null) {
+ LOG.warn("replayDropTableFromEvent [{}] failed", tableName);
+ }
Review Comment:
missing `else`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
