kaijchen commented on code in PR #21634:
URL: https://github.com/apache/doris/pull/21634#discussion_r1267482351
##########
be/src/common/config.h:
##########
@@ -591,8 +591,12 @@ DECLARE_mInt32(memory_maintenance_sleep_time_ms);
DECLARE_mInt32(memory_gc_sleep_time_ms);
// Sleep time in milliseconds between load channel memory refresh iterations
+// Deprecated
DECLARE_mInt64(load_channel_memory_refresh_sleep_time_ms);
+// Sleep time in milliseconds between memtbale flush mgr memory refresh
iterations
+DECLARE_mInt64(memtable_flush_mgr_memory_refresh_sleep_time_ms);
Review Comment:
Maybe call it `memtable_memory_check_interval_ms`?
##########
be/src/common/daemon.cpp:
##########
@@ -276,14 +276,14 @@ void Daemon::memory_gc_thread() {
}
}
-void Daemon::load_channel_tracker_refresh_thread() {
+void Daemon::memtable_flush_mgr_tracker_refresh_thread() {
// Refresh the memory statistics of the load channel tracker more
frequently,
// which helps to accurately control the memory of LoadChannelMgr.
- while (!_stop_background_threads_latch.wait_for(
-
std::chrono::milliseconds(config::load_channel_memory_refresh_sleep_time_ms)) &&
Review Comment:
Backward compatibility is broken by just deleting this config.
`load_channel_memory_refresh_sleep_time_ms` should act as an alias of
`memtable_flush_mgr_memory_refresh_sleep_time_ms`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
